Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orml-xtokens Astar integration. #1000

Merged
merged 2 commits into from
Aug 16, 2023
Merged

orml-xtokens Astar integration. #1000

merged 2 commits into from
Aug 16, 2023

Conversation

shaunxw
Copy link
Member

@shaunxw shaunxw commented Aug 10, 2023

Pull Request Summary

Integrate orml-xtokens into Astar runtime. Also moved shared XCM config code into primitives.

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@shaunxw shaunxw added astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. labels Aug 10, 2023
Dinonard
Dinonard previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashutoshvarma
ashutoshvarma previously approved these changes Aug 11, 2023
View reviewed changes
gitofdeepanshu
gitofdeepanshu previously approved these changes Aug 11, 2023
View reviewed changes
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/utils/macro/src 0% 0% ❌
chain-extensions/xvm/src 0% 0% ❌
precompiles/assets-erc20/src 76% 0% ➖
precompiles/sr25519/src 79% 0% ➖
chain-extensions/types/dapps-staking/src 0% 0% ❌
pallets/block-reward/src 85% 0% ✔
pallets/ethereum-checked/src 48% 0% ❌
pallets/dapps-staking/src 81% 0% ✔
pallets/pallet-xcm/src 53% 0% ➖
pallets/xvm/src 46% 0% ❌
pallets/collator-selection/src 69% 0% ➖
chain-extensions/types/xvm/src 0% 0% ❌
precompiles/batch/src 80% 0% ✔
precompiles/substrate-ecdsa/src 78% 0% ➖
precompiles/utils/src 68% 0% ➖
pallets/contracts-migration/src 0% 0% ❌
chain-extensions/pallet-assets/src 0% 0% ❌
precompiles/utils/src/testing 62% 0% ➖
precompiles/xcm/src 84% 0% ✔
pallets/custom-signatures/src 51% 0% ➖
primitives/src/xcm 66% 0% ➖
pallets/xc-asset-config/src 53% 0% ➖
chain-extensions/dapps-staking/src 0% 0% ❌
chain-extensions/types/assets/src 0% 0% ❌
precompiles/xvm/src 83% 0% ✔
primitives/src 64% 0% ➖
pallets/dapps-staking/src/pallet 85% 0% ✔
precompiles/dapps-staking/src 93% 0% ✔
Summary 57% (2552 / 4460) 0% (0 / 0) ➖

Minimum allowed line rate is 50%

@shaunxw shaunxw merged commit 5046c6c into master Aug 16, 2023
@shaunxw shaunxw deleted the feat/xtokens-astar branch August 16, 2023 04:19
@ashutoshvarma ashutoshvarma mentioned this pull request Aug 23, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitofdeepanshu gitofdeepanshu gitofdeepanshu approved these changes

@ashutoshvarma ashutoshvarma ashutoshvarma approved these changes

@Dinonard Dinonard Dinonard left review comments

Assignees
No one assigned
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaunxw @Dinonard @ashutoshvarma @gitofdeepanshu